Fix for issue preventing validation of url with only whitespace #11549
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Previously, the clean function was assigning
tile.data[nodeid]
as None if the url provided was entirely whitespace, which prevented it from being validated. This then prevented further data entry after saving.The clean function now separates out some of the logic, so that the url_label is replaced with None if blank or whitespace, but the full
tile.data[nodeid]
is only assigned as None if both values are falsey. This means that blank but non-empty url strings still go through to validation.Issues Solved
Closes #10796
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments